Add Snowflake ingestion config options: allow_empty_schemas, skip_standard_edition_check #12841
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following config options are added with this PR. allow_empty_schemas was added to avoid a generic permissions error that was being thrown when attempting to ingest schemas with no tables/views. skip_standard_edition_check was added in order to avoid redundant/repetitive/costly calls to
show_tags()
which was causing unnecessary "Cloud" compute credits to be spent in Snowflake. These config options have been tested thoroughly in Stage environment of Optum datahub fork.allow_empty_schemas
- If set to True, allows schemas with no tables or views to be processed, without reporting generic permissions error. Default is False.skip_standard_edition_check
- If set to True, assumes this is Datahub Enterprise Edition, and skips the check for standard edition. Default is False.Checklist