fix(ingest/snowflake): Fixing table rename query handling #12852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
datahub-cyborg
bot
added
the
needs-review
hsheth2
approved these changes
Mar 12, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
hsheth2
approved these changes
Mar 13, 2025
| query=query, | ||
| session_id=session_id, | ||
| timestamp=timestamp, | ||
| ), "Processing ALTER ... RENAME should result in a proper TableRename object" |
There was a problem hiding this comment.
in general, we don't need comments on asserts - the test feels pretty clear already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For table renames
operationTypeinobject_modified_by_ddldictionary isALTER. We need to checkquery_typeto see whether it was table-rename-kind-of-alter. Taking this into consideration I added this value toparse_ddl_query. Considering pre-existing logic there I had to swap order ofifconditions to achieve intended behavior (the logic didn't change beyond that).