Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create, remove and list commands for workspaces #131

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Added create, remove and list commands for workspaces #131

merged 5 commits into from
Jul 29, 2020

Conversation

andreas-nesheim
Copy link

As referenced in Issue 130. Added a new CLI command for workspace. These commands include:

  • create
  • list
  • remove

Hope you find this useful. I'd be willing to have a go at implementing commands for adding and removing signals to the workspace as well if this PR looks good.

@nblumhardt
Copy link
Member

Thank you @andreas-nesheim - looks great.

We can definitely fill in the "modify" part; I was wondering, though, should we look at supporting this on create as:

seqcli workspace create -t 'test' --signal=signal-123 --signal=signal-124 --dashboard=dashboard-456

Keen to hear opinions :-)

@andreas-nesheim
Copy link
Author

Sure, that sounds like a good idea! I'll try to implement it.

@andreas-nesheim
Copy link
Author

I tried to add the options that we discussed now, but I see one of the tests in Appveyor is failing. When I try to run it locally it works, though.

@nblumhardt
Copy link
Member

Thanks! I think the CI failure is a timing issue we haven't managed to flush out; it'd be unrelated to this PR. I've queued the build back up, everything looks good, we can tinker from here :-) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants