Extend app hosting to cover Seq requirements #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seq currently ships Seq.Apps.GenericHost and Seq.Apps.Interrogator binaries for working with .NET app packages. These two executables load and execute app packages, and read app package metadata.
In a near-future Seq release, we'd like to replace GenericHost and Interrogator with corresponding commands from
seqcli
. Theapp run
command already implements the generic hosting functionality, with some minor feature gaps.By closing those gaps, and adding a new
seqcli app define
command to play the role of Interrogator, we can remove the two standalone executables.This will:
seqcli app run
) match the runtime app environment exactly, making behavior around dependent assembly resolution and binding more predictableThere are three parts to this work:
seqcli
Before this can be merged:
seqcli app define
, to read app metadata from .NET attributesAdd code-level documentation for the app metadata formatshould be covered in docsapp define
app run
to consume settings from environment variables, so that command-line length limits are avoided, and app configuration can trivially include newlines and other non-CLI-safe charactersapp run