Allow updating signals #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This would be a great addition. Since |
|
Yes, that is a great point. I will amend that |
|
@nblumhardt |
|
Thank you; looks good, I'll need a few spare minutes to review, but think this is the way to go 👍 |
|
Thanks again! Sorry about the delay; this will make it into the 2020.3 release. |
This was referenced Sep 30, 2020
Merged
|
Hi. I'm facing an issue, which relates to this ticket. The id defined in the imported signal is ignored, and the new signal is getting a different id. Please check this ticket: datalust/seq-tickets#1718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing signals if a signal with the same id is found it will update the values instead of inserting a new one.
Related to #145