Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pack as dotnet tool #152

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add pack as dotnet tool #152

merged 1 commit into from
Sep 30, 2020

Conversation

andymac4182
Copy link
Contributor

Based on #143

@andymac4182 andymac4182 force-pushed the feat/pack_as_tool branch 2 times, most recently from e482e77 to 589db87 Compare September 27, 2020 10:00
@andymac4182 andymac4182 marked this pull request as ready for review September 28, 2020 23:52
nblumhardt
nblumhardt reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! Had one minor suggestion; once this is in I'll add what we need to get it publishing to NuGet.org 😎

@andymac4182
Copy link
Contributor Author

I haven't dealt with nuget and appveyor. Not sure if this is something you would like me to add as well since I can't add the encrypted tokens.

@nblumhardt nblumhardt merged commit 1f390d5 into datalust:dev Sep 30, 2020
@nblumhardt
Copy link
Member

Thanks, yes, I'll add the publishing config, needs some setup on the NuGet side 👍

This was referenced Sep 30, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andymac4182 @nblumhardt