Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-13171: Fix query_filters guardrail using the index analyzer instead of the query analyzer #1615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adelapena
Copy link

The method RowFilter.AnalyzableExpression#numFilteredValues, which is used by the query_filters guardrail, uses the index analyzer, whereas it should use the query analyzer. This could lead to wrongly triggering the guardrail in some cases.

@adelapena adelapena self-assigned this Feb 28, 2025
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1615 rejected by Butler


2 new test failure(s) in 2 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
...s.f.GlobalTidyConcurrencyTest.tidyVsGetRaceTest regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 3 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants