Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch LineUp dependency from next to version number #603

Closed
thinkh opened this issue Dec 29, 2021 · 0 comments · Fixed by #604
Closed

Switch LineUp dependency from next to version number #603

thinkh opened this issue Dec 29, 2021 · 0 comments · Fixed by #604
Assignees
@thinkh
Labels
dependencies Pull requests that update a dependency file

Comments

@thinkh
Copy link
Member

thinkh commented Dec 29, 2021 •
edited
Loading

Currently, we are using the npm tag next for the lineupjs dependency (see

tdp_core/package.json

Line 85 in 846ddb0

"lineupjs": "next",
). According to npm this is corresponds with version 4.3.0-alpha.0 which is older than the latest release (= 4.4.0).

grafik

I also noticed that the next tag hasn't been replaced with the actual version number in the last TDP Core release.

Hence, I suggest to switch to actual version numbers for lineupjs, since there is no "rolling develop release". Once a new LineUp version (next or latest) has been released we can update the dependency version number here and test our apps accordingly. Plus: we must not change the dependency from next to a version and back when releasing TDP Core.
@thinkh thinkh added the dependencies Pull requests that update a dependency file label Dec 29, 2021
@thinkh thinkh self-assigned this Dec 29, 2021
@thinkh thinkh mentioned this issue Dec 29, 2021
Merged
@thinkh thinkh linked a pull request Dec 29, 2021 that will close this issue
Switch LineUp dependency from next to version number #604
Merged
thinkh added a commit that referenced this issue Dec 29, 2021
@thinkh
Update LineUp dependency to v4.4.0
3000ba4 
#603
@keckelt keckelt mentioned this issue Mar 9, 2022
Open
thinkh added a commit that referenced this issue May 3, 2022
@thinkh
Update to lineupjs to version ~4.6.0
f169aae 
#603
@ghost ghost closed this as completed in ec0c443 Jun 15, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thinkh thinkh

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch LineUp dependency from next to version number datavisyn/tdp_core
1 participant
@thinkh