-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to top-level /content
directory
#86
Conversation
Thanks for this PR ❤️ |
Sorry, been slammed with work but looking to take some time to catch up on oss so will take a look over the weekend 👍 |
Hi, is everything ready for a merge ? Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, and thanks for waiting for me to get to this!
* Migrate to top-level `/content` directory * Migrate playground to Nuxt 4 directory structure * Use `^` instead of `>=` for version range * Bump version --------- Co-authored-by: Dave Stewart <[email protected]>
Hey @JakeIsMeh ... So I merged your code but have since found out that the playground doesn't work at all. I've renamed It's been so long since I looked at the code I'm not 100% sure myself what isn't working. I'm not going to publish anything to NPM until I can be sure what's going on. I'm away on holiday right now, but would like to get this over the line seeing as we've started! |
Hey @davestewart, I had a gander at this and want to say that none of the module's code has rotted, but rather, this was a series of unfortunate events. I'm not sure which issues you ran into specifically but I did encounter some issues when setting up the playground to test again.
Afterwards, the playground works just fine. I've uploaded the repo here for reference: Cheers |
Quick update: with further testing, the only issues I could find are:
|
Do you think this is a Nuxt 4 issue? |
Hi @davestewart, quick update, I've opened an issue for the build failure (#88). As for the linked json data issue, I'm not sure if it ever worked with SSG as I didn't utilize it, but it seems like either a pre-existing bug, or if it did used to work during SSG, one caused by changes to the internals of |
package-lock.json
should be regenerated aspackage.json
was modified and playground dependencies might have to be upgraded, which I am leaving to you. (the branch is open for maintainers to edit)(Side note: I used
pnpm
as I encountered many issues withnpm
while trying to set up the dev environment for this repo.)closes: #85