Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #68

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Update dependencies #68

merged 1 commit into from
Sep 11, 2020

Conversation

metab0t
Copy link
Contributor

@metab0t metab0t commented Sep 9, 2020

No description provided.

@davidavdav
Copy link
Owner

Hi, thanks.

How does this patch pass the tests? I don't see CI output in this PR

@metab0t
Copy link
Contributor Author

metab0t commented Sep 11, 2020

I have tested it locally and tests work fine on my machine.
I don't know why CI is not triggered by this PR.

@davidavdav davidavdav merged commit 9f899d3 into davidavdav:master Sep 11, 2020
@davidavdav
Copy link
Owner

@metab0t
Copy link
Contributor Author

metab0t commented Sep 11, 2020

https://travis-ci.org/github/davidavdav/GaussianMixtures.jl after merge

The stacktrace of Julia nightly seems weird.
The error happens in libuv functions.

@nalimilan
Copy link
Collaborator

Would it be possible to tag a new release? That would help for example cstjean/ScikitLearn.jl#92.

@davidavdav
Copy link
Owner

@JuliaTagBot minor

@nalimilan
Copy link
Collaborator

Thanks, but I don't see any release in the General registry, and Project.toml still says 0.3.2. JuliaTagBot only creates tags, right?

(While you're at it, there are a few outstanding PRs bumping dependencies.)

@davidavdav
Copy link
Owner

I don't know. I've tried to release by using github release https://github.com/davidavdav/GaussianMixtures.jl/releases/tag/v0.3.3 but maybe that is not the way to release.

All the bots completely confuse me, the system keeps changing, and I have no idea how it currently works. I am with this guy https://discourse.julialang.org/t/release-a-new-version-of-registered-packages-again/47765

@nalimilan
Copy link
Collaborator

Yes now you have to update Project.toml, and then add a comment to a commit (not a PR) saying @JuliaRegistrator register. JuliaTagBot only creates tags afterwards (but that's somewhat independent from actual releases). You probably have to enable JuliaRegistrator on the project.

@JuliaRegistrator
Copy link

Error while trying to register: Register Failed
@nalimilan, it looks like you don't have collaborator status on this repository.

@davidavdav
Copy link
Owner

Thanks, I hope it is done correctly now!

@ExpandingMan
Copy link

Hey guys, this never actually got tagged, can we tag this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants