Fix parameters missing from command line call signatures #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters (or ellipsis) should show up in call signatures even when the index of the current argument is unknown.
|
Nice. I think the idea is good. I'm not 100% sure about the usability, but since you are the one using this feature and not me, I think you should just try it out :) @blueyed Maybe you can check this as well (and merge if you want). |
|
Looks good!
Happens with Python 2 only: created a new issue to track it at #500. |
|
This got closed as I was about to write this which is good. I was just going to clarify that this was just a bug fix. This is how the standard call signatures work and how the command line call signatures worked because I put in the ellipsis stuff. I just missed this case in the refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters (or ellipsis) should show up in call signatures even when the index of the current argument is unknown. This mostly happens when there are more arguments typed than in Jedi's idea of the signature. Currently it just shows empty parentheses even if there are parameters (this applies to command line signatures only).
PS: When the testing fails in
test/signatures.vimI get aUnicodeEncodeErrorfromconftest.pyever since using the ellipsis character.