Fix residual comparison for ExtTofts model & Combine plot functions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notZaki
changed the title
|
I like this a lot. Currently trying to figure out why the builds are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
In science.jl. Fixed bug with ExtTofts model. Large regions of the QIBA4 phantom couldn't make it past the residual comparison, so the modelmap and residual map had big patches of zeros. However, the parameter maps still got produced correctly because they were being accepted before the residual comparison even took place - an incorrect behavior providing the correct result.
In validate.jl. I combined
analyze4()andanalyze6()into a single function because they share a lot of code. This doesn't exactly have any definite advantage, but it does considerably reduce the lines of code, and might make future edits easier. The drawback is that the range and ticks on the colorbars now use default values instead of the pre-defined phantom-specific values they had before.Since the code for drawing the maps is similar, it could be wrapped in a function to further reduce the amount of code lines - but these all seem to be incidental changes.