-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer need *noisy.mat files or PyPlot #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
1 similar comment
I like these changes. I wish I had thought to auto generate the noisy data before I published the paper. Maybe someday we can reset the git archive to make it leaner. For now, can you squash the commits into bigger groups, like three commits based on the three bullet points above? |
I squashed them down to six commits. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request - which probably should've been split into two PRs - tries to speed up the installation process by making two main changes.
Delete the *noisy.mat files from the package itself and use a function to make the noisy data.
The function to make the noisy data was adapted from the python scripts.
The *noisy.mat files were deleted because they take up roughly ~70% of the package size, so deleting them should speed up the download step. But, now that I think about it, the download size probably won't change because the old *noisy.mat files will still be stored in the git history. D'oh well.
Allow
validate()
anddemo()
to work without needing PyPlot (issue Breaks when PyPlot not installed #6) - the functions will run but the plotting step will be skipped if PyPlot is not installed.This should speed up the installation step by not requiring PyPlot and it's dependencies to be installed.
(Unrelated minor change) When running
validate()
, the parameter maps now use a fixed colourscale based on the range of the true values. This ensures that the noiseless and noisy runs produce parameter maps with the same colourscale - making them easier to compare.Aside: The CCC for QIBA 4 ve was 0.698 - slightly below the 0.70 cutoff. In order to squeeze past the cutoff, I modified the tests to round the CCC to two significant digits.