Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for testing #47

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Add dependencies for testing #47

merged 2 commits into from
Sep 6, 2019

Conversation

notZaki
Copy link
Contributor

@notZaki notZaki commented Sep 6, 2019

I was checking some old code and the tests kept failing. This PR should hopefully make the Travis tests pass.


Changes:

  • Add dependencies to Project.toml
    • This was done somewhat manually by navigating to the project directory and then:
     Julia>]activate .
     Julia>]add <dependencyNameOneByOne>
    
    • Alternatively, I think ]resolve would've done the same thing
  • Travis uses the installed python version and so matplotlib needs to be installed for it. There might be a way to force it to use the Conda.jl, but I didn't have time to figure it out.
  • I (re?)commented that script section in .travis.yml to enable the default test script. I think the default script is better at handling different Julia versions, but I also don't know if there was a reason why it was overridden in the first place.

@davidssmith
Copy link
Owner

Thank you thank you thank you!

I've tried a few times in my spare time to update the code, and I'm just too far removed from the current Julia situation to fix it properly.

@davidssmith davidssmith merged commit cdb2e02 into davidssmith:master Sep 6, 2019
@notZaki notZaki deleted the addDependencies branch September 7, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants