Skip to content

Commit

Permalink
restore fadeDeselectedArea for ordinal bar charts
Browse files Browse the repository at this point in the history
where there is no concept of "no brushing"
ref #1422 #1401
  • Loading branch information
gordonwoodhull committed Apr 20, 2018
1 parent 3e21ace commit c4e3f75
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/bar-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,6 @@ dc.barChart = function (parent, chartGroup) {
}

_chart.fadeDeselectedArea = function (brushSelection) {
if (!_chart.brushOn()) {
return;
}
var bars = _chart.chartBodyG().selectAll('rect.bar');

if (_chart.isOrdinal()) {
Expand All @@ -231,7 +228,7 @@ dc.barChart = function (parent, chartGroup) {
bars.classed(dc.constants.SELECTED_CLASS, false);
bars.classed(dc.constants.DESELECTED_CLASS, false);
}
} else {
} else if (_chart.brushOn()) {
if (!_chart.brushIsEmpty(brushSelection)) {
var start = brushSelection[0];
var end = brushSelection[1];
Expand Down

0 comments on commit c4e3f75

Please sign in to comment.