-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunburst : doesn't recenter when redrawn #1490
Comments
Hi @Frozenlock, would you care to give this a try and see if the proposed fix works? I believe you are correct about what this line does. |
We also require a test - we need to make a new resizing example. I can handle that if you care to contribute the fix. |
I'll let you handle the resizing example. |
By the way, I noticed that pie chart doesn't resize as cleanly as the other charts (including Sunburst). |
Behavior
Expected : the sunburst chart should recenter itself like the pie-chart when redrawn width different width/height.
Actual : the sunburst chart doesn't move.
Potential cause
The sunburst chart doesn't have a cx/cy based transition in the
drawChart
function like the pie-chart does.Pie chart : https://github.com/dc-js/dc.js/blob/develop/src/pie-chart.js#L124
Sunburst chart : https://github.com/dc-js/dc.js/blob/develop/src/sunburst-chart.js#L94
The text was updated successfully, but these errors were encountered: