-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunburst dc v3 #1388
Sunburst dc v3 #1388
Conversation
Done with current round of changes.
|
Rebase to |
Well, we have our first case of a feature that work on D3v4 but did not work in D3v5. Rebased to |
Wow very interesting. Details please, when you have time to figure it out! |
It turned out to be quite simple, the example was using one of scheme category 20 colors. Which was causing all colors to be undefined and the chart to draw everything in white.
I will push a commit soon.
|
The failing test case is probably related to a weak test case in color-spec, will fix that as a separate PR. |
Thanks @blairn, @tehsenaus, @kum-deepak! This is merged for 3.0.0 |
I'm not sure in which opened or closed Sunburst issues I should ask this... I'm not sure if the problem lies with the value accessor or how I build up my dimensions... |
Hi @Frozenlock! I did see your question on the users group but I didn't know the answer off the top of my head and I got distracted by other things. :) It's completely okay to "bump a thread" by replying to yourself, if it's getting ignored. There's always a lot going on. I'll try to take a look today. |
This is an straight upgrade of #1337 with as little changes that I could.
Will look into qualitative aspects soon.