Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunburst dc v3 #1388

Closed
wants to merge 15 commits into from
Closed

Sunburst dc v3 #1388

wants to merge 15 commits into from

Conversation

kum-deepak
Copy link
Collaborator

This is an straight upgrade of #1337 with as little changes that I could.

Will look into qualitative aspects soon.

@kum-deepak
Copy link
Collaborator Author

Done with current round of changes.

@kum-deepak
Copy link
Collaborator Author

Rebase to dc.js/develop caused issues, will investigate before pushing the changes.

@kum-deepak kum-deepak changed the base branch from 3.0 to develop April 22, 2018 11:53
@kum-deepak
Copy link
Collaborator Author

Well, we have our first case of a feature that work on D3v4 but did not work in D3v5.

Rebased to dc.js/develop and then downgraded D3 to v4, works for now. Need to dig deeper. 😄

@gordonwoodhull
Copy link
Contributor

Wow very interesting. Details please, when you have time to figure it out!

@kum-deepak
Copy link
Collaborator Author

kum-deepak commented Apr 23, 2018 via email

@kum-deepak
Copy link
Collaborator Author

The failing test case is probably related to a weak test case in color-spec, will fix that as a separate PR.

@gordonwoodhull
Copy link
Contributor

Thanks @blairn, @tehsenaus, @kum-deepak!

This is merged for 3.0.0

@kum-deepak kum-deepak deleted the sunburst-dc-v3 branch April 28, 2018 17:23
@Frozenlock
Copy link
Contributor

I'm not sure in which opened or closed Sunburst issues I should ask this...
@gordonwoodhull @kum-deepak
Would you mind taking a look at my question posted here?

I'm not sure if the problem lies with the value accessor or how I build up my dimensions...

@gordonwoodhull
Copy link
Contributor

Hi @Frozenlock! I did see your question on the users group but I didn't know the answer off the top of my head and I got distracted by other things. :)

It's completely okay to "bump a thread" by replying to yourself, if it's getting ignored. There's always a lot going on.

I'll try to take a look today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants