Filter printer does not correctly print out multi-element filters #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 5, 2017 22:34
…)` being the default
|
Makes a lot of sense. Will cherry-pick the relevant commits and merge soon! |
|
Thanks @ialarmedalien! Merged for 3.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a hierarchical chart (the sunburst chart) where the filtered dimension is an array, the filter printer only prints out the first two members of the array. This alters the printer so every element of the array is printed out.
Apologies for the odd commit history; I accidentally reused an old branch.
Added a fix for #1474, altering the documentation in
stock.jsforchart.controlsUseVisibility.