feat: sell, buy & cancel estates #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
reviewed
Oct 1, 2018
src/Translation/locales/es.json
Outdated
| @@ -232,38 +282,18 @@ | |||
| "requested": "Pedido", | |||
| "required_deposit": "Depósito requerido: {deposit}" | |||
| }, | |||
| "name": { | |||
| "estate": "Inmuebles", | |||
cazala
previously requested changes
Oct 1, 2018
| } | ||
|
|
||
| static defaultProps = { | ||
| publication: { price: 0 } |
There was a problem hiding this comment.
we should let the UI handle an undefined/null publication rather than mocking a default one
| } | ||
|
|
||
| renderMessage() { | ||
| const { wallet, publication } = this.props |
There was a problem hiding this comment.
The following +80 lines are pretty much the same as the ones in BuyParcelPage, could we componentize them?
nachomazzara
force-pushed
the
feat/sell-states
branch
from
8086010 to
29cf3b7
Compare
nachomazzara
force-pushed
the
feat/sell-states
branch
from
dc380e4 to
52434b2
Compare
nachomazzara
changed the title
nachomazzara
force-pushed
the
feat/sell-states
branch
from
05a58c2 to
51a9ed8
Compare
nicosantangelo
changed the title
nachomazzara
force-pushed
the
feat/sell-states
branch
from
6791916 to
6a84eea
Compare
nicosantangelo
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346, #345 & #496