feat: marketplace v2 monitor #501
Conversation
nicosantangelo
changed the title
nicosantangelo
changed the title
monitor/reducers/estateReducer.js
Outdated
| estate.token_id | ||
| }" remove land (${x},${y})` | ||
| ) | ||
| const coordinates = Parcel.splitId(parcelId) |
There was a problem hiding this comment.
Maybe we should change it to const [x, y] = Parcel.splitId(parcelId)
There was a problem hiding this comment.
Hm, I didn't do that so I can parse the coordinates in the line below this one:
const parcel = { x: Number(coordinates[0]), y: Number(coordinates[1]) }
you think it should look like:
let [x, y] = Parcel.splitId(parcelId)
x = Number(x)
y = Number(y)
const parcel = { x, y }
or
const [x, y] = Parcel.splitId(parcelId)
const parcel = { x: Number(x), y: Number(y) } // I like this one I think
or maybe
const [x, y] = Parcel.splitId(parcelId).map(Number) // I don't like this too much
const parcel = { x, y }
So I can do the same thing everywhere :D
There was a problem hiding this comment.
I did it!
I prefer The second one
monitor/reducers/estateReducer.js
Outdated
| } | ||
| }, | ||
| { token_id: _estateId } | ||
| { token_id: estate.token_id } |
There was a problem hiding this comment.
If for count we use the the id maybe we should use the id here too or use the token_id for get counts
There was a problem hiding this comment.
Yes! I didn't see this one, I used .id in the other cases
monitor/reducers/mortgageReducer.js
Outdated
| @@ -35,18 +56,17 @@ export async function mortgageReducer(events, event) { | |||
| expiresAt, | |||
| payableAt, | |||
| interestRate, | |||
| punitoryInterestRate | |||
| punitoryInterestRate, | |||
| block_time_created_at | |||
There was a problem hiding this comment.
Super minor but, We are using blockTime for everything related to block_time_created_at and block_time_updated_at. Is there any reason why we are using a different name here? I mean block_time_created_at instead of blockTime
| expires_at: expiresAt, | ||
| marketplace_address: marketplace.getAddress(), | ||
| asset_type: marketplace.getType(), | ||
| block_time_created_at: blockTime, |
There was a problem hiding this comment.
Related to the minor I mentioned
| }) | ||
| ]) | ||
| await Publication.delete({ | ||
| asset_id: assetId, |
There was a problem hiding this comment.
Maybe we should delete also by asset_type to avoid undesired deletions
| }, | ||
| { contract_id } | ||
| ), | ||
| Parcel.update({ owner: winner }, { id: parcelId }) | ||
| Asset.update({ owner: winner }, { id: assetId }) |
There was a problem hiding this comment.
As we are going to have buyer maybe we should check the arg winner or buyer
| @@ -14,94 +14,6 @@ export class BlockchainEvent extends Model { | |||
| 'address' | |||
| ] | |||
Closes #342 #502