Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to deno deploy cache api implementation #741

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

ItamarRocha
Copy link
Member

@ItamarRocha ItamarRocha commented Aug 2, 2024

Documentation for Deno's Edge Cache is available at https://docs.deno.com/deploy/manual/edge-cache/

This commit contains the following alterations:

  • Add CACHE_API as the default cache engine, which replaces KV in our DD websites (This does not affect the k8s websites, as they are by default using the FILE_SYSTEM cache).
  • Change LOADER_CACHE_START_THRESHOLD env var to 0
  • Change LOADER_CACHE_SIZE to 1_024_000
  • Add Content-Type and Content-Length fields to the cached response header

Results

Before After
image image
Without Web Cache DD Web Cache DD

Copy link
Contributor

@mcandeia mcandeia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you measure the perf impact of doing an encoding operation?

@matheusgr matheusgr force-pushed the cache_api_integration branch 2 times, most recently from b691cbe to 04d13f0 Compare September 14, 2024 01:01
ItamarRocha and others added 3 commits September 25, 2024 14:23
Documentation for deno's Edge Cache are available at https://docs.deno.com/deploy/manual/edge-cache/

This commit contains the following alterations:
* Add CACHE_API as default cache engine, which replaces KV in our DD websites (This does not afect the k8s websites, as they are by default using the FILE_SYSTEM cache).
* Change LOADER_CACHE_START_THRESHOLD env var to 0
* Change LOADER_CACHE_SIZE to 1_024_000
* Add Content-Type field to cached response header
* Add Content-Length field to cached response header if length is available
@matheusgr matheusgr force-pushed the cache_api_integration branch from 34dc816 to 1c7aa86 Compare September 25, 2024 17:23
@matheusgr matheusgr requested a review from mcandeia September 26, 2024 13:22
@matheusgr matheusgr merged commit 68e0621 into main Sep 26, 2024
2 checks passed
@matheusgr matheusgr deleted the cache_api_integration branch September 26, 2024 17:27
matheusgr added a commit that referenced this pull request Sep 26, 2024
matheusgr added a commit that referenced this pull request Sep 26, 2024
@matheusgr matheusgr restored the cache_api_integration branch September 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants