-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to deno deploy cache api implementation #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcandeia
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you measure the perf impact of doing an encoding operation?
b691cbe
to
04d13f0
Compare
Documentation for deno's Edge Cache are available at https://docs.deno.com/deploy/manual/edge-cache/ This commit contains the following alterations: * Add CACHE_API as default cache engine, which replaces KV in our DD websites (This does not afect the k8s websites, as they are by default using the FILE_SYSTEM cache). * Change LOADER_CACHE_START_THRESHOLD env var to 0 * Change LOADER_CACHE_SIZE to 1_024_000 * Add Content-Type field to cached response header * Add Content-Length field to cached response header if length is available
34dc816
to
1c7aa86
Compare
mcandeia
requested changes
Sep 25, 2024
mcandeia
approved these changes
Sep 26, 2024
matheusgr
added a commit
that referenced
this pull request
Sep 26, 2024
This reverts commit 68e0621.
matheusgr
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for Deno's Edge Cache is available at https://docs.deno.com/deploy/manual/edge-cache/
This commit contains the following alterations:
Results