Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log noise from autocomplete #796

Closed
JamesXNelson opened this issue Jun 28, 2021 · 1 comment
Closed

Reduce log noise from autocomplete #796

JamesXNelson opened this issue Jun 28, 2021 · 1 comment
Assignees
@JamesXNelson
Labels
feature request New feature or request triage

Comments

@JamesXNelson
Copy link
Member

The recently merged autocomplete winds up spamming the logs with piles of uninteresting messages about parsing documents for completion. The log level needs to be dropped to trace(), and the logger itself should be specific to the parser, rather than passing in the logger from the rpc endpoint.
@JamesXNelson JamesXNelson added feature request New feature or request triage labels Jun 28, 2021
@JamesXNelson JamesXNelson self-assigned this Jun 28, 2021
JamesXNelson added a commit to JamesXNelson/deephaven-core that referenced this issue Jun 28, 2021
@JamesXNelson
Reduce autocomplete logging noise (core deephaven#796)
8bcf549
JamesXNelson added a commit to JamesXNelson/deephaven-core that referenced this issue Jun 28, 2021
@JamesXNelson
Reduce autocomplete logging noise (core deephaven#796)
264461d
JamesXNelson added a commit to JamesXNelson/deephaven-core that referenced this issue Jun 28, 2021
@JamesXNelson
Reduce autocomplete logging noise (core deephaven#796)
9b5d482
JamesXNelson added a commit that referenced this issue Jun 28, 2021
@JamesXNelson
Reduce autocomplete logging noise (#796) (#797)
ce3c2ac 
Reduce autocomplete logging noise (core #796)
@nbauernfeind
Copy link
Member

Colin and I agree the current behavior around auto-complete logging resolves this issue.

jmao-denver pushed a commit to jmao-denver/deephaven-core that referenced this issue Apr 11, 2022
@JamesXNelson @jmao-denver
Reduce autocomplete logging noise (deephaven#796) (deephaven#797)
2ef4663 
Reduce autocomplete logging noise (core deephaven#796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesXNelson JamesXNelson

Labels
feature request New feature or request triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbauernfeind @JamesXNelson