Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert JSAPI examples from Groovy #904

Closed
mofojed opened this issue Jul 26, 2021 · 0 comments · Fixed by #1220
Closed

Convert JSAPI examples from Groovy #904

mofojed opened this issue Jul 26, 2021 · 0 comments · Fixed by #1220
Labels
feature request New feature or request triage

Comments

@mofojed
Copy link
Member

mofojed commented Jul 26, 2021

Right now there are a couple JSAPI examples (table_viewport.html, table_filter.html, table_sort.html) that execute snippets of Groovy code. However, we default to Python on startup now.

Could do one of the following:

  1. Convert examples to Python
  2. Convert examples to use JSAPI commands instead of running a snippet of code (requires some other JSAPI changes)
  3. Display error if wrong language selected, prompting user to start up in the correct language
@mofojed mofojed added feature request New feature or request triage labels Jul 26, 2021
@mofojed mofojed mentioned this issue Jul 26, 2021
Merged
mofojed added a commit to mofojed/deephaven-core that referenced this issue Sep 8, 2021
@mofojed
Convert JS API examples to python
f17672c 
- By default, deephaven-core runs Python
- Examples were in Groovy. Convert them to Python to work with default config
- Add a new basic example that simple opens a static table and outputs the data. This super simple example will be referenced from the tutorials in the docs.
- Fixes deephaven#904
@mofojed mofojed mentioned this issue Sep 8, 2021
Merged
mofojed added a commit that referenced this issue Sep 16, 2021
@mofojed
Convert JS API examples to python (#1220)
5fbd942 
* Convert JS API examples to python

- By default, deephaven-core runs Python
- Examples were in Groovy. Convert them to Python to work with default config
- Add a new basic example that simple opens a static table and outputs the data. This super simple example will be referenced from the tutorials in the docs.
- Fixes #904

* Clean up the basic example a bit

* Clean up based on review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert JS API examples to python mofojed/deephaven-core
1 participant
@mofojed