Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Parallel Select Implementation from Deephaven Enterprise. #1749

Merged
merged 21 commits into from
Jan 4, 2022
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0b79e0e
Cross port parallel select from Deephaven enterprise.
cpwright Dec 28, 2021
436c980
spotless, from hell's heart I stab at thee.
cpwright Dec 28, 2021
bf600ad
Merge remote-tracking branch 'upstream/main' into nightly/cpw_portpar…
cpwright Dec 28, 2021
7fc9567
fix test merge conflicts.
cpwright Dec 28, 2021
a2d82fb
fix test merge conflicts.
cpwright Dec 28, 2021
0c3a77e
spotless
cpwright Dec 28, 2021
856de0c
revert unrelated newline change
cpwright Dec 29, 2021
0dd2455
Merge remote-tracking branch 'upstream/main' into nightly/cpw_portpar…
cpwright Dec 30, 2021
969ee13
Apply formatting suggestions from code review
cpwright Jan 3, 2022
ac00841
Only check columns if we have not already fired.
cpwright Jan 3, 2022
3295a44
spotless
cpwright Jan 3, 2022
ce3cb5f
Fix from review.
cpwright Jan 3, 2022
9a7a1ce
Update engine/table/src/main/java/io/deephaven/engine/table/impl/sele…
cpwright Jan 3, 2022
ed9847d
Update engine/table/src/main/java/io/deephaven/engine/table/impl/sele…
cpwright Jan 3, 2022
bf8b333
Update engine/table/src/main/java/io/deephaven/engine/table/impl/sele…
cpwright Jan 3, 2022
5135b42
code review pass 2
cpwright Jan 3, 2022
ae0c5f8
Merge branch 'nightly/cpw_portparallelselect' of github.com:cpwright/…
cpwright Jan 3, 2022
c667d38
code review before renames
cpwright Jan 4, 2022
88b4581
Move performance entry and thread pool.
cpwright Jan 4, 2022
586277c
remove subentry name
cpwright Jan 4, 2022
a46557b
Merge remote-tracking branch 'upstream/main' into nightly/cpw_portpar…
cpwright Jan 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update engine/table/src/main/java/io/deephaven/engine/table/impl/sele…
…ct/analyzers/SelectAndViewAnalyzer.java

Co-authored-by: Ryan Caudy <[email protected]>
cpwright and rcaudy authored Jan 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ed9847d5ebdfb31bda6ac1c76561fa19c48d1ff4
Original file line number Diff line number Diff line change
@@ -263,9 +263,9 @@ public void close() {
* @param upstream the upstream update
* @param toClear rows that used to exist and no longer exist
* @param helper convenience class that memoizes reusable calculations for this update
* @param onCompletion called when an inner column is complete, the outer layer should pass the completion on to
* other layers and if it all of it's dependencies have been satisfied schedule execution of that column
* update
* @param onCompletion Called when an inner column is complete. The outer layer should pass the {@code onCompletion}
* on to other layers and if it and all of its dependencies have been satisfied schedule execution
* of that column update.
*/
public abstract void applyUpdate(TableUpdate upstream, RowSet toClear, UpdateHelper helper,
JobScheduler jobScheduler, SelectLayerCompletionHandler onCompletion);