Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch export response handling pyclient #1859

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix batch export response handling pyclient #1859

merged 1 commit into from
Jan 21, 2022

Conversation

devinrsmith
Copy link
Member

Follow up #1858

@devinrsmith devinrsmith added this to the Jan 2022 milestone Jan 21, 2022
@devinrsmith devinrsmith self-assigned this Jan 21, 2022
jmao-denver
jmao-denver approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the error handling improvement might better be done as part of an overall better logging/configuration support, e.g. instead of swallowing the exception, log a warning to the log file and the terminal, ...

@devinrsmith devinrsmith merged commit 8953666 into deephaven:main Jan 21, 2022
@devinrsmith devinrsmith deleted the fix-pyclient-batch-response branch January 21, 2022 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

Assignees

@devinrsmith devinrsmith

Labels
NoDocumentationNeeded python-client
Projects
None yet
Milestone
Jan 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@devinrsmith @jmao-denver