Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hotspot-impl module JAVA_PUBLIC. #2479

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti added this to the Jun 2022 milestone Jun 6, 2022
@jcferretti jcferretti requested a review from devinrsmith June 6, 2022 23:31
@jcferretti jcferretti self-assigned this Jun 6, 2022
@devinrsmith
Copy link
Member

Looks like the combined javadoc task is failing. This may be something we can work around, or it may be more fundamentally related to this #2404. I can help diagnose tomorrow.

@devinrsmith
Copy link
Member

Note: an earlier version of this PR would fail when it comes to release time (wouldn't be able to create the publication for hotspot-impl). I've instructed Cristian to update the PR, and I created a follow-up ticket to make CI better at catching this kind of thing.

@jcferretti jcferretti merged commit d16aa9e into deephaven:main Jun 7, 2022
@jcferretti jcferretti deleted the cfs-hotspot-impo-public-0 branch June 7, 2022 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants