Add `updateBy` functionality to Deephaven Community #2516

lbooker42 · 2022-06-10T22:01:13Z

No description provided.

…by-oa

devinrsmith

Skipped a lot of the implementation. I think we should consider chatting about Immutables when you have time.

engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByControl.java

engine/api/src/main/java/io/deephaven/engine/table/ColumnUpdateClause.java

engine/api/src/main/java/io/deephaven/engine/table/UpdateByClause.java

engine/api/src/main/java/io/deephaven/engine/table/ColumnUpdateClause.java

engine/table/src/main/java/io/deephaven/engine/table/impl/SimpleSourceTable.java

engine/table/src/main/java/io/deephaven/engine/table/impl/TableWithDefaults.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByOperatorFactory.java

devinrsmith

I think we still need to consider Selectable instead of MatchPair... given that any thought?

engine/api/src/main/java/io/deephaven/engine/table/EmaControl.java

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/CumProdSpec.java

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/CumSumSpec.java

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/EmaSpec.java

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/FillBySpec.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByControl.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByOperatorFactory.java

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/EmaSpec.java

… into lab-updateby-oa

engine/api/src/main/java/io/deephaven/engine/table/Table.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByControl.java

table-api/src/main/java/io/deephaven/api/updateBy/spec/TimeScale.java

table-api/src/main/java/io/deephaven/api/updateBy/spec/CumProdSpec.java

table-api/src/main/java/io/deephaven/api/updateBy/spec/TimeScale.java

table-api/src/main/java/io/deephaven/api/updateBy/spec/CumMinMaxSpec.java

table-api/src/main/java/io/deephaven/api/updateBy/ColumnUpdateClause.java

table-api/src/main/java/io/deephaven/api/updateBy/spec/UpdateBySpec.java

engine/table/src/main/java/io/deephaven/engine/table/impl/TableWithDefaults.java

engine/api/src/main/java/io/deephaven/engine/table/Table.java

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByControl.java

engine/api/src/main/java/io/deephaven/engine/table/Table.java

table-api/src/main/java/io/deephaven/api/updateBy/UpdateByControl.java

table-api/src/main/java/io/deephaven/api/updateby/UpdateByControl.java

devinrsmith

So close!

lbooker42 and others added 4 commits June 10, 2022 14:59

End of Week commit

5150614

merged upstream

7b49e94

spotless and WIP

3e981fc

Merge branch 'deephaven:main' into lab-updateby-oa

8216802

lbooker42 self-assigned this Jun 14, 2022

lbooker42 added feature request New feature or request DocumentationNeeded labels Jun 14, 2022

lbooker42 added this to the Jun 2022 milestone Jun 14, 2022

lbooker42 requested review from rcaudy, abaranec and devinrsmith June 14, 2022 17:07

lbooker42 added the query engine label Jun 14, 2022

lbooker42 added 3 commits June 14, 2022 11:45

Tests passing, ready for initial review

a7271b0

Merge remote-tracking branch 'origin/lab-updateby-oa' into lab-update…

5784fdc

…by-oa

minor doc changes

50f6724

devinrsmith reviewed Jun 14, 2022

View reviewed changes

Addressed immutable PR comments

5c6b87a

devinrsmith reviewed Jun 16, 2022

View reviewed changes

lbooker42 added 2 commits June 16, 2022 10:32

Renames to remove 'index' references

1449e7f

More PR comments addressed

00c4978

devinrsmith reviewed Jun 21, 2022

View reviewed changes

engine/api/src/main/java/io/deephaven/engine/table/updateBySpec/EmaSpec.java Outdated Show resolved Hide resolved

lbooker42 and others added 9 commits June 21, 2022 16:28

Moved TimeScale to a new Immutable class

9c2c4e0

updated hash table files to add constructor visibility

92a077c

converted interface to use Selectable

5be99f1

Merge branch 'main' into lab-updateby-oa

746192b

Merge branch 'deephaven:main' into lab-updateby-oa

94b7a38

API changes

213968a

Merge branch 'lab-updateby-oa' of github.com:lbooker42/deephaven-core…

2f4b891

… into lab-updateby-oa

spotless applied

78b7254

spotless applied

6c2e894

lbooker42 force-pushed the lab-updateby-oa branch from 3be0126 to 6c2e894 Compare June 24, 2022 00:15

devinrsmith requested changes Jun 27, 2022

View reviewed changes

Another round of PR comments addressed

b7fb32b

devinrsmith self-requested a review June 28, 2022 16:54

devinrsmith reviewed Jun 28, 2022

View reviewed changes

More PR-related updates

8937bee

devinrsmith reviewed Jun 28, 2022

View reviewed changes

engine/table/src/main/java/io/deephaven/engine/table/impl/TableWithDefaults.java Outdated Show resolved Hide resolved

engine/api/src/main/java/io/deephaven/engine/table/Table.java Outdated Show resolved Hide resolved

devinrsmith self-requested a review June 28, 2022 23:58

devinrsmith reviewed Jun 29, 2022

View reviewed changes

engine/table/src/main/java/io/deephaven/engine/table/impl/UpdateByControl.java Outdated Show resolved Hide resolved

Moved UpdateByControl to 'table-api' and cleanup

c6ed557

devinrsmith self-requested a review June 29, 2022 17:36

devinrsmith requested changes Jun 29, 2022

View reviewed changes

PR comments addressed

dbc48f9

devinrsmith reviewed Jun 29, 2022

View reviewed changes

table-api/src/main/java/io/deephaven/api/updateby/UpdateByControl.java Outdated Show resolved Hide resolved

devinrsmith requested changes Jun 29, 2022

View reviewed changes

spotless and PR changes

3d405b5

devinrsmith previously approved these changes Jun 29, 2022

View reviewed changes

Fixed OOB failure (caused by bug in CumMinMaxSpec.applicableTo)

7145cb2

lbooker42 dismissed devinrsmith’s stale review via 7145cb2 June 29, 2022 21:16

Merge upstream

be260ef

devinrsmith self-requested a review June 29, 2022 23:19

devinrsmith approved these changes Jun 29, 2022

View reviewed changes

devinrsmith mentioned this pull request Jun 30, 2022

replicateAllSafe does not correctly regen license headers #2574

Closed

lbooker42 merged commit feb6c8e into deephaven:main Jun 30, 2022

github-actions bot locked and limited conversation to collaborators Jun 30, 2022

lbooker42 deleted the lab-updateby-oa branch June 26, 2024 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `updateBy` functionality to Deephaven Community #2516

Add `updateBy` functionality to Deephaven Community #2516

lbooker42 commented Jun 10, 2022

devinrsmith left a comment

devinrsmith left a comment

devinrsmith left a comment

Add updateBy functionality to Deephaven Community #2516

Add updateBy functionality to Deephaven Community #2516

Conversation

lbooker42 commented Jun 10, 2022

devinrsmith left a comment

Choose a reason for hiding this comment

devinrsmith left a comment

Choose a reason for hiding this comment

devinrsmith left a comment

Choose a reason for hiding this comment

Add `updateBy` functionality to Deephaven Community #2516

Add `updateBy` functionality to Deephaven Community #2516