Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateBy functionality to Deephaven Community #2516

Merged
merged 26 commits into from
Jun 30, 2022

Conversation

lbooker42
Copy link
Contributor

No description provided.

@lbooker42 lbooker42 self-assigned this Jun 14, 2022
@lbooker42 lbooker42 added this to the Jun 2022 milestone Jun 14, 2022
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped a lot of the implementation. I think we should consider chatting about Immutables when you have time.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to consider Selectable instead of MatchPair... given that any thought?

@devinrsmith devinrsmith self-requested a review June 28, 2022 16:54
@devinrsmith devinrsmith self-requested a review June 28, 2022 23:58
@devinrsmith devinrsmith self-requested a review June 29, 2022 17:36
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close!

devinrsmith
devinrsmith previously approved these changes Jun 29, 2022
@devinrsmith devinrsmith self-requested a review June 29, 2022 23:19
@lbooker42 lbooker42 merged commit feb6c8e into deephaven:main Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
@lbooker42 lbooker42 deleted the lab-updateby-oa branch June 26, 2024 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants