Add UpdateByTable QST #2609
Merged
Add UpdateByTable QST #2609
+354
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
commented
Jun 30, 2022
Comment on lines
1778
to
1779
| Table updateBy(@NotNull Collection<? extends UpdateByClause> operations, | ||
| @NotNull Collection<? extends Selectable> byColumns); |
There was a problem hiding this comment.
Note: I left this out of your original review (b/c it was easy for me to add in this PR); but from a QST point of view, I need to be able to call updateBy w/ these exact parameters. Usage in TableAdapterImpl.
rcaudy
reviewed
Jun 30, 2022
| @@ -517,6 +519,23 @@ TOPS raj(TABLE rightTable, Collection<? extends JoinMatch> columnsToMatch, | |||
|
|
|||
| // ------------------------------------------------------------------------------------------- | |||
|
|
|||
| TOPS updateBy(UpdateByClause operation); | |||
There was a problem hiding this comment.
Should the JavaDoc be lifted up to here, rather than on Table?
There was a problem hiding this comment.
Maybe? At least right now, the javadoc refers to #getRowSet which isn't a concept at the TableOperations level. We've been a bit inconsistent in these regards - some of the TableOperations have javadoc, others just on Table.
rcaudy
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2608