Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WritableSourceColumn's SinkFillers Have State and Should not be Singletons #3317

Merged
merged 1 commit into from
Jan 18, 2023
Merged

WritableSourceColumn's SinkFillers Have State and Should not be Singletons #3317

merged 1 commit into from
Jan 18, 2023

Conversation

nbauernfeind
Copy link
Member

Fixes #3315.

@nbauernfeind nbauernfeind added bug Something isn't working query engine NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jan 17, 2023
@nbauernfeind nbauernfeind added this to the Jan 2023 milestone Jan 17, 2023
@nbauernfeind nbauernfeind self-assigned this Jan 17, 2023
@rcaudy rcaudy merged commit 09e4332 into deephaven:main Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@cpwright cpwright Awaiting requested review from cpwright

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Milestone
Jan 2023
Development

Successfully merging this pull request may close these issues.

WritableColumnSource's SinkFiller Implementations Should not be Singletons
2 participants
@nbauernfeind @rcaudy