Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/* branches version bumping is weird #557

Open
mofojed opened this issue Jun 14, 2024 · 5 comments
Open

release/* branches version bumping is weird #557

mofojed opened this issue Jun 14, 2024 · 5 comments
Labels
bug Something isn't working
Milestone
Backlog

Comments

@mofojed
Copy link
Member

mofojed commented Jun 14, 2024 •
edited
Loading

  • Can't just run the ./release.sh command, need to specify the patch
    • Manually ran cog bump --package "ui" --patch" which got most of the way there... except it seemed to bump the minor version. Crap.
      • Could do cog bump --package "ui" --version 0.15.3, or add the --dry-run flag to see it before bumping
      • That doesn't work though, because it thinks the current version is still what's on the main branch...
    • Then needed to do git push origin release/ui-v0.15
  • What do we set for the dist-tag? Since the branch will be dependent on the package...
    • Or do we just have one branch for "vplus", and tag it as such?
  • Tries to push to main instead of the same branch
  • Python Plugins should be published when the Release is created, instead of triggered from a tag push
    • Right now it's being published as part of the modified-plugin.yml workflow on a tag push, rather than triggering when the release is created.
@mofojed mofojed added bug Something isn't working triage labels Jun 14, 2024
@vbabich vbabich added this to the Backlog milestone Jun 18, 2024
@vbabich vbabich removed the triage label Jun 18, 2024
mofojed added a commit to mofojed/deephaven-plugins that referenced this issue Jun 21, 2024
@mofojed
build: Set distTag to ui-v0.15 for this release branch
90bad7b 
- Note there's still some weirdness around how we should handle dist-tags, will address with deephaven#557 fixes. This just makes sure I don't publish a version "latest" from this branch
- Update the changelogPreset to use conventionalcommits (was done in web-client-ui with deephaven/web-client-ui#2054)
@mofojed mofojed mentioned this issue Jun 21, 2024
Merged
mofojed added a commit that referenced this issue Jun 21, 2024
@mofojed
build: Set distTag to ui-v0.15 for this release branch (#570)
30126ad 
- Note there's still some weirdness around how we should handle
dist-tags, will address with #557 fixes. This just makes sure I don't
publish a version "latest" from this branch
- Update the changelogPreset to use conventionalcommits (was done in
web-client-ui with deephaven/web-client-ui#2054)
@mofojed
Copy link
Member Author

mofojed commented Jun 21, 2024

Sounds like bump-profiles are what we need: https://docs.cocogitto.io/guide/#bump-profiles

@mofojed mofojed self-assigned this Jun 24, 2024
@mofojed
Copy link
Member Author

mofojed commented Jun 28, 2024

Breaking it down a bit, can use conventional-changelog-cli to create the changelog, e.g.

./node_modules/.bin/conventional-changelog -p conventionalcommits --tag-prefix ui-v --commit-path ./plugins/ui

@mofojed
Copy link
Member Author

mofojed commented Jun 28, 2024

Release Please looks interesting: https://github.com/googleapis/release-please

@mofojed
Copy link
Member Author

mofojed commented Jun 28, 2024 •
edited
Loading

Cocogitto doesn't seem to support patching from a hotfix branch: cocogitto/cocogitto#241
That seems like a major oversight, especially considering they mention hotfix in the Bump Profiles section: https://docs.cocogitto.io/guide/#bump-hooks
I'm a little confused.
Looks like it may already be addressed with an open PR when it merges?

@mofojed mofojed modified the milestones: Backlog, July 2024 Jul 9, 2024
@mofojed
Copy link
Member Author

mofojed commented Jul 9, 2024

Release bumping in general needs better confirmation before the release is actually created.

@mofojed mofojed modified the milestones: July 2024, September 2024 Sep 3, 2024
@mofojed mofojed modified the milestones: September 2024, Backlog Oct 23, 2024
@mofojed mofojed removed their assignment Oct 23, 2024
@mofojed mofojed mentioned this issue Jan 13, 2025
Merged
mofojed added a commit that referenced this issue Jan 13, 2025
@mofojed
build: Update the changelogPreset to use conventionalcommits, allow r…
8aa6c38 
…elease branches to bump versions (#1081)

- Allow release branches to bump versions - we need this for hotfix
branches, and already have it on the ui-v0.15 branch:
2803fea
- Need to update template to the correct format. Already did this on the
`release/ui-v0.15` branch: #570
- Take note there are still some issues to beware of when bumping a
release branch:
#557
mofojed added a commit that referenced this issue Jan 13, 2025
@mofojed
build: Update the changelogPreset to use conventionalcommits, allow r…
825a5c0 
…elease branches to bump versions (#1081)

- Allow release branches to bump versions - we need this for hotfix
branches, and already have it on the ui-v0.15 branch:
2803fea
- Need to update template to the correct format. Already did this on the
`release/ui-v0.15` branch: #570
- Take note there are still some issues to beware of when bumping a
release branch:
#557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@vbabich @mofojed