feat: UI table respond to non-primitive prop changes #1046
Conversation
mattrunyon
requested review from
dgodinez-dh and
mofojed
and removed request for
a team and
dgodinez-dh
|
|
||
| const log = Log.module('@deephaven/js-plugin-ui/UITable'); | ||
|
|
||
| function useDeepEquals<T>(value: T): T { |
There was a problem hiding this comment.
It might be worth placing this in it's own file so it can be used in other code.
There was a problem hiding this comment.
I agree. I think this and the other hook would be good in @deephaven/react-hooks, but I was being lazy and avoiding needing to merge to web-client-ui, publish, then consume here. I can do that though
There was a problem hiding this comment.
Add JS docs for this hook as well.
|
|
||
| const log = Log.module('@deephaven/js-plugin-ui/UITable'); | ||
|
|
||
| function useDeepEquals<T>(value: T): T { |
There was a problem hiding this comment.
Add JS docs for this hook as well.
|
|
||
| const alwaysFetchColumns = useMemo(() => { | ||
| if (alwaysFetchColumnsArray[0] === true) { | ||
| if (modelColumns.length > 500) { | ||
| if (columns.length > 500) { |
There was a problem hiding this comment.
nit: The 500 should be a constant, as it's used in the error message below.
| setError( | ||
| `Table has ${modelColumns.length} columns, which is too many to always fetch. ` + | ||
| `Table has ${columns.length} columns, which is too many to always fetch. ` + |
There was a problem hiding this comment.
You should use the useThrowError hook above here. Looks like you only used in useUITableModel even though it applies here as well.
|
ui docs preview (Available for 14 days) |
|
I addressed the review comments, but left them unresolved so they are easier to verify since this PR was stale for a while |
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
Fixes #982
Also fixes a bug I found while implementing this where adding a custom column in the UI would cause formatting rule
if_clauses to be removed.