Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ui as a tree #1067

Merged
merged 12 commits into from
Dec 30, 2024
Merged

docs: ui as a tree #1067

merged 12 commits into from
Dec 30, 2024

Conversation

dgodinez-dh
Copy link
Contributor

@@ -0,0 +1,152 @@
# Your UI as a Tree
Copy link
Contributor

@dsmmcken dsmmcken Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commentary on all the meta docs.

your_ui_as_a_tree.md should be your-ui-as-a-tree.md

I think you started using underscores to match the pattern of the components, but the components are literally the function names, where as these are just articles and should match the seperators used everywhere else.

Just noticed this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of small changes.


Identifying these categories of components are useful for understanding data flow and performance of your component.

## The dependency tree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this section really makes sense to include... or at least we should continue using the phrase "app" instead of "query", since we use the word "app" above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this section.

mofojed
mofojed previously approved these changes Dec 20, 2024
Copy link
Contributor

@jjbrosnan jjbrosnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many comments

@dgodinez-dh dgodinez-dh requested a review from mofojed December 20, 2024 19:06
@dgodinez-dh dgodinez-dh merged commit 2e1a725 into deephaven:main Dec 30, 2024
18 checks passed
@dgodinez-dh dgodinez-dh deleted the dag_UiTree branch January 10, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants