-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ui as a tree #1067
docs: ui as a tree #1067
Conversation
@@ -0,0 +1,152 @@ | |||
# Your UI as a Tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commentary on all the meta docs.
your_ui_as_a_tree.md should be your-ui-as-a-tree.md
I think you started using underscores to match the pattern of the components, but the components are literally the function names, where as these are just articles and should match the seperators used everywhere else.
Just noticed this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of small changes.
|
||
Identifying these categories of components are useful for understanding data flow and performance of your component. | ||
|
||
## The dependency tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this section really makes sense to include... or at least we should continue using the phrase "app" instead of "query", since we use the word "app" above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this section.
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not many comments
https://deephaven.atlassian.net/browse/DOC-240