docs: ui as a tree #1067
Merged
docs: ui as a tree #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmmcken
requested changes
Dec 18, 2024
| @@ -0,0 +1,152 @@ | |||
| # Your UI as a Tree | |||
There was a problem hiding this comment.
This is commentary on all the meta docs.
your_ui_as_a_tree.md should be your-ui-as-a-tree.md
I think you started using underscores to match the pattern of the components, but the components are literally the function names, where as these are just articles and should match the seperators used everywhere else.
Just noticed this now.
mofojed
requested changes
Dec 18, 2024
|
|
||
| Identifying these categories of components are useful for understanding data flow and performance of your component. | ||
|
|
||
| ## The dependency tree |
There was a problem hiding this comment.
I'm not sure this section really makes sense to include... or at least we should continue using the phrase "app" instead of "query", since we use the word "app" above.
There was a problem hiding this comment.
Removed this section.
Co-authored-by: Mike Bender <[email protected]>
mofojed
previously approved these changes
Dec 20, 2024
jjbrosnan
reviewed
Dec 20, 2024
Co-authored-by: margaretkennedy <[email protected]>
jjbrosnan
approved these changes
Dec 20, 2024
mofojed
approved these changes
Dec 20, 2024
margaretkennedy
approved these changes
Dec 20, 2024
dsmmcken
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deephaven.atlassian.net/browse/DOC-240