Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disclosure #1068

Merged
merged 15 commits into from
Feb 6, 2025
Merged

feat: disclosure #1068

merged 15 commits into from
Feb 6, 2025

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Dec 18, 2024

Closes #1037

@ethanalvizo ethanalvizo self-assigned this Dec 18, 2024
@ethanalvizo ethanalvizo marked this pull request as ready for review December 26, 2024 21:06
@ethanalvizo ethanalvizo requested a review from mofojed December 31, 2024 20:52
margaretkennedy
margaretkennedy previously approved these changes Jan 3, 2025
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update plugins/ui/src/js/package.json to use the v102 versions of the @deephaven/ packages that include Disclosure to fix the build errors.

@ethanalvizo ethanalvizo requested a review from mofojed January 17, 2025 21:29
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add Disclosure to e2e tests as well. Would be cool to add your own e2e test instead of the render_all catchall.

@ethanalvizo ethanalvizo requested a review from mofojed January 27, 2025 14:18
@ethanalvizo ethanalvizo requested a review from mofojed February 3, 2025 05:57
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Eric mentioned, you'll need to add it to another panel and update the snapshots for the e2e tests. Or add it as a separate component and add a new test for it.

@ethanalvizo ethanalvizo requested a review from mofojed February 5, 2025 14:41
@mofojed mofojed merged commit 6934bf2 into deephaven:main Feb 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.disclosure
4 participants