-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disclosure #1068
feat: disclosure #1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update plugins/ui/src/js/package.json
to use the v102 versions of the @deephaven/
packages that include Disclosure to fix the build errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add Disclosure to e2e tests as well. Would be cool to add your own e2e test instead of the render_all catchall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Eric mentioned, you'll need to add it to another panel and update the snapshots for the e2e tests. Or add it as a separate component and add a new test for it.
Closes #1037