New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: label prop typing #1071

Merged

wusteven815 merged 1 commit into deephaven:main from wusteven815:988-label-typing

Dec 20, 2024

Contributor

wusteven815 commented Dec 19, 2024 •

edited

Loading

Fixes Typing for label prop on many components is incorrect #988
Adds NodeType, which mirrors the React Node type

wusteven815 self-assigned this

wusteven815 force-pushed the 988-label-typing branch from 132672b to 6c74087 Compare

December 19, 2024 18:48


          update label type

e2c6dc6

wusteven815 force-pushed the 988-label-typing branch from 6c74087 to e2c6dc6 Compare

December 19, 2024 19:33

wusteven815 marked this pull request as ready for review

December 19, 2024 19:58

wusteven815 requested a review from mofojed

December 19, 2024 19:58

mofojed approved these changes

View reviewed changes

wusteven815 merged commit 716b3d9 into deephaven:main

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet