docs: respond to events #1083
Merged
docs: respond to events #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
previously approved these changes
Jan 17, 2025
|
|
||
| Yes. Event handlers are the best place for side effects. | ||
|
|
||
| Unlike rendering functions, event handlers do not need to be [pure](../describing/pure_components.md), so it’s a great place to change something. For example, you can change an input’s value in response to typing, or change a list in response to a button press. |
There was a problem hiding this comment.
Guessing you'll want a link to the state document after that is done as well.
I'm a little bit surprised there's no mention of use_callback for memoizing event handlers here, but guess it's not really the spot for it. Seems strange they're almost completely omitted from the Learn section of the React docs (I'm not seeing them anywhere in there). 🤷
Co-authored-by: margaretkennedy <[email protected]>
margaretkennedy
approved these changes
Jan 21, 2025
mattrunyon
pushed a commit
to mattrunyon/deephaven-plugins
that referenced
this pull request
Feb 3, 2025
https://deephaven.atlassian.net/browse/DOC-346 --------- Co-authored-by: margaretkennedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deephaven.atlassian.net/browse/DOC-346