Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure ReactPanelErrorBoundary handles undefined children #1089

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: Ensure ReactPanelErrorBoundary handles undefined children #1089

merged 2 commits into from
Jan 21, 2025

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jan 20, 2025

  • ReactPanelErrorBoundary would throw an error if children was undefined
  • Just render null if children is undefined
  • Tested using the steps in DH-18461. Unable to figure out steps to reproduce in just DHC.
    • There may still be a fix higher up in Enterprise, but this at least ensures ReactPanelErrorBoundary is more robust and we don't totally euchre our layout

@mofojed
fix: Ensure ReactPanelErrorBoundary handles undefined children
b955958 
- ReactPanelErrorBoundary would throw an error if children was undefined
- Just render `null` if `children` is `undefined`
- Tested using the steps in DH-18461. Unable to figure out steps to reproduce in just DHC.
  - There may still be a fix higher up in Enterprise, but this at least ensures ReactPanelErrorBoundary is more robust and we don't totally euchre our layout
@mofojed mofojed requested a review from mattrunyon January 20, 2025 20:13
@mofojed mofojed self-assigned this Jan 20, 2025
@mofojed mofojed merged commit e622b83 into deephaven:main Jan 21, 2025
17 checks passed
mofojed added a commit to mofojed/deephaven-plugins that referenced this pull request Jan 21, 2025
@mofojed
fix: Ensure ReactPanelErrorBoundary handles undefined children (deeph…
b2476d9 
…aven#1089)

- ReactPanelErrorBoundary would throw an error if children was undefined
- Just render `null` if `children` is `undefined`
- Tested using the steps in DH-18461. Unable to figure out steps to
reproduce in just DHC.
- There may still be a fix higher up in Enterprise, but this at least
ensures ReactPanelErrorBoundary is more robust and we don't totally
euchre our layout
mofojed added a commit that referenced this pull request Jan 21, 2025
@mofojed
fix: Ensure ReactPanelErrorBoundary handles undefined children (#1089) (
2c31622 
#1092)

- ReactPanelErrorBoundary would throw an error if children was undefined
- Just render `null` if `children` is `undefined`
- Tested using the steps in DH-18461. Unable to figure out steps to
reproduce in just DHC.
- There may still be a fix higher up in Enterprise, but this at least
ensures ReactPanelErrorBoundary is more robust and we don't totally
euchre our layout
mattrunyon pushed a commit to mattrunyon/deephaven-plugins that referenced this pull request Feb 3, 2025
@mofojed @mattrunyon
fix: Ensure ReactPanelErrorBoundary handles undefined children (deeph…
3349265 
…aven#1089)

- ReactPanelErrorBoundary would throw an error if children was undefined
- Just render `null` if `children` is `undefined`
- Tested using the steps in DH-18461. Unable to figure out steps to
reproduce in just DHC.
- There may still be a fix higher up in Enterprise, but this at least
ensures ReactPanelErrorBoundary is more robust and we don't totally
euchre our layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrunyon mattrunyon mattrunyon approved these changes

Assignees

@mofojed mofojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @mattrunyon