docs: queueing a series of updates #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Jan 27, 2025
| set_friend_count(lambda fc: fc * 2) | ||
| ``` | ||
|
|
||
| If you prefer more verbose code, another common convention is to repeat the full state variable name, like `set_enabled(lambda enabled: not enabled)`, or to use a prefix like `set_enabled(lambda prev_enabled: not prev_enabled)`. |
There was a problem hiding this comment.
We should mention multi-threaded cases somewhere. Have a note that in multi-threaded cases they aren't batched by default and you need to use the use_render_queue to ensure they do get batched if you're going to do work from a background thread.
Got a note about it in the use_render_queue docs: https://salmon.deephaven.io/core/ui/docs/hooks/use_render_queue/#batch-updates
This is different than React because JS is single threaded.
There was a problem hiding this comment.
Added a note and linked to the use_render_queue docs.
Co-authored-by: Mike Bender <[email protected]>
mofojed
previously approved these changes
Jan 27, 2025
Co-authored-by: margaretkennedy <[email protected]>
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
Co-authored-by: margaretkennedy <[email protected]>
|
ui docs preview (Available for 14 days) |
margaretkennedy
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deephaven.atlassian.net/browse/DOC-366