Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ui.markdown was styling code incorrectly #1106

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: ui.markdown was styling code incorrectly #1106

merged 1 commit into from
Feb 4, 2025

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Feb 3, 2025

  • Use the markdown-editor-container styling so it appears the same as a markdown control
  • Removing the unnecessary padding which we don't want as part of deephaven.ui
  • Add e2e tests

@mofojed
fix: ui.markdown was styling code incorrectly
8151f4e 
- Use the markdown-editor-container styling so it appears the same as a markdown control
- Removing the unnecessary padding which we don't want as part of deephaven.ui
- Add e2e tests
@mofojed mofojed self-assigned this Feb 3, 2025
@mofojed mofojed requested review from a team and vbabich and removed request for a team February 3, 2025 23:04
@mofojed mofojed merged commit c84db85 into deephaven:main Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbabich vbabich vbabich approved these changes

Assignees

@mofojed mofojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @vbabich