Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-18415: Cannot expand rows after applying rollup to ui.table #1109

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Feb 4, 2025

Fixes #1079
Tested with the steps in DH-18415

@mattrunyon mattrunyon requested a review from a team February 4, 2025 23:10
@mattrunyon mattrunyon self-assigned this Feb 4, 2025
@mattrunyon mattrunyon requested review from vbabich and removed request for a team February 4, 2025 23:10
@mattrunyon mattrunyon marked this pull request as draft February 5, 2025 19:46
@mattrunyon
Copy link
Collaborator Author

Moving to draft because I think the actual fix (without breaking other things) will need to be completely different code from what this fix is

@mattrunyon mattrunyon marked this pull request as ready for review February 5, 2025 20:27
@mattrunyon mattrunyon marked this pull request as draft February 5, 2025 20:31
Copy link

github-actions bot commented Feb 6, 2025

ui docs preview (Available for 14 days)

1 similar comment
Copy link

github-actions bot commented Feb 6, 2025

ui docs preview (Available for 14 days)

Copy link

github-actions bot commented Feb 6, 2025

ui docs preview (Available for 14 days)

@mattrunyon mattrunyon marked this pull request as ready for review February 6, 2025 04:40
@mattrunyon mattrunyon merged commit 0d09ef4 into deephaven:main Feb 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot expand rows after applying a rollup to tables wrapped with ui.table
2 participants