-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: preserving and resetting state #1118
Conversation
ui docs preview (Available for 14 days) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. One question about the counters in the table and a small correction near the end.
app ||--|| counter1 : has | ||
app ||--|| counter2 : has | ||
counter1 { | ||
count _0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason there's an underscore before the value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mermaid would not allow a value that starts with a numeric character. It needs to start with a letter or an underscore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh that's because it expects type name
pair, and you could add a comment after: https://mermaid.js.org/syntax/entityRelationshipDiagram.html#attribute-keys-and-comments
I think that would look better. Add the type, then add a comment for the value, e.g. int count 0
instead of count _0
plugins/ui/docs/managing-state/preserving-and-resetting-state.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Bender <[email protected]>
ui docs preview (Available for 14 days) |
plugins/ui/docs/managing-state/preserving-and-resetting-state.md
Outdated
Show resolved
Hide resolved
Co-authored-by: margaretkennedy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change count _0
to int count 0
ui docs preview (Available for 14 days) |
ended up with int count "0" |
ui docs preview (Available for 14 days) |
https://deephaven.atlassian.net/browse/DOC-462