Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: preserving and resetting state #1118

Merged
merged 11 commits into from
Feb 25, 2025

Conversation

dgodinez-dh
Copy link
Contributor

Copy link

ui docs preview (Available for 14 days)

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. One question about the counters in the table and a small correction near the end.

app ||--|| counter1 : has
app ||--|| counter2 : has
counter1 {
count _0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason there's an underscore before the value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mermaid would not allow a value that starts with a numeric character. It needs to start with a letter or an underscore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that's because it expects type name pair, and you could add a comment after: https://mermaid.js.org/syntax/entityRelationshipDiagram.html#attribute-keys-and-comments
I think that would look better. Add the type, then add a comment for the value, e.g. int count 0 instead of count _0

Copy link

ui docs preview (Available for 14 days)

@dgodinez-dh dgodinez-dh requested a review from mofojed February 24, 2025 13:38
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change count _0 to int count 0

Copy link

ui docs preview (Available for 14 days)

@dgodinez-dh
Copy link
Contributor Author

Change count _0 to int count 0

ended up with int count "0"

Copy link

ui docs preview (Available for 14 days)

@dgodinez-dh dgodinez-dh merged commit 374a9e9 into deephaven:main Feb 25, 2025
17 checks passed
@dgodinez-dh dgodinez-dh deleted the dag_PreserveReset branch February 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants