feat: DH-18652 Programmatically display aggregates rows with ui.table #1131
+180
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrunyon
changed the title
mattrunyon
changed the title
|
ui docs preview (Available for 14 days) |
1 similar comment
|
ui docs preview (Available for 14 days) |
mattrunyon
force-pushed
the
mattrunyon_dh-18652
branch
from
bd88c17 to
f5780bb
Compare
|
ui docs preview (Available for 14 days) |
mattrunyon
requested review from
mofojed,
dsmmcken,
a team and
bmingles
and removed request for
margaretkennedy,
mofojed,
dsmmcken and
a team
|
ui docs preview (Available for 14 days) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931
Currently need to run with the local web-client-ui packages deephaven/web-client-ui#2385. Those will be merged and this PR updated once the rest of it is approved so we don't need multiple web-client-ui PRs potentially.
Should we change this to
totalsinstead ofaggregations? Then it doesn't match the sidebar menu so probably either change in both places or neither. My concern is it's confusing you can dot.aggand nowui.table(t, aggregations)and they are completely different