Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unwanted linebreaks in tutorial.md #1133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jnumainville
Copy link
Collaborator

@jnumainville jnumainville commented Mar 12, 2025

I believe this was arising because a double space at the end of a line was treated as a hardbreak by MyST-parser
Then, sphinx-markdown-builder has no special treatment for raw nodes so both of the raw nodes were just being inserted as is, ignoring the format.
For now, the quickest workaround is just removing the double spaces.

Copy link

ui docs preview (Available for 14 days)

@jnumainville
Copy link
Collaborator Author

jnumainville commented Mar 12, 2025

I'm not sure why the lines are showing up in the preview? The <br /> and \\\\ are gone locally

Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have been caught by prettier being enforced against .md

@mattrunyon
Copy link
Collaborator

I need to update the PR preview link because we changed the order of some URL segments. Looks like they are gone

https://preview.deephaven.io/core/ui/pr-1133/docs/tutorial/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants