-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add e2e tests for cloud distros #1259
Open
noahpb
wants to merge
81
commits into
main
Choose a base branch
from
feat/e2e-test-nightly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahpb
commented
Mar 14, 2025
- name: Test UDS Core | ||
run: uds run -f tasks/test.yaml uds-core-non-k3d --set EXCLUDED_PACKAGES="metrics-server" | ||
continue-on-error: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting the continue-on-error: true
here. EKS VPC CNI permits outbound traffic to the internet for the network tests, despite not having a NetworkPolicy to explicitly allow this. Ignoring failures for now until we decide how to proceed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts our nightly pipelines (RKE2, EKS and AKS) to run our e2e tests. This PR generally takes our e2e tests that we currently use for k3d and expands them to run against additional k8s distributions and architectures. Notable changes are:
*.uds.dev
from apps within the cluster./tasks/test.yaml
calleduds-core-non-k3d
for triggering e2e tests against various distros. This task includes an optional input calledEXCLUDED_PACKAGES
that allows callers to skip uneccessary tests, such asmetrics-server
for some distros.architecture
for the./src/test/package
./tasks/utils.yaml
calledsetup-hosts
that configures the local/etc/hosts
file to point to*.uds.dev
and*.admin.uds.dev
domains that are hosted on the cluster that e2e tests are running against../test/jest/network.spec.ts
to produce more meaningful error messages when timeouts are occurring during connectivity tests (before these would run indefinitely and the jest timeout would ultimately be reached)../test/jest/network.spec.ts
, changes explicitexpect().toBe("503")
responses toexpect().not.toBe("200")
to account for different behavior of cluster CNIs when rejecting traffic due toNetworkPolicy
deny rules.Related Issue
Fixes #729
Type of change
Steps to Validate
Checklist before merging