Update boardgame.io to 0.45.2 #105

matthewejones · 2021-07-21T14:31:09Z

Updated boardgame.io to version 0.45.2

Resolves #69

matthewejones · 2021-07-21T15:47:27Z

Downloading files causes an internal server error:

TypeError: Cannot read property 'G' of undefined
      at getThreats (C:\Users\jonesm\Documents\elevation-of-privilege\src\server\publicApi.js:155:27)
      at C:\Users\jonesm\Documents\elevation-of-privilege\src\server\publicApi.js:128:25
      at async cors (C:\Users\jonesm\Documents\elevation-of-privilege\node_modules\@koa\cors\index.js:56:32)

matthewejones · 2021-07-22T16:07:26Z

Turn order broken

matthewejones · 2021-07-27T12:54:05Z

Turn order now works (I hope)

ChristophNiehoff · 2021-07-27T13:26:06Z

@matthewejones Do you know if PR #87 gets obsolete when this is merged?

matthewejones · 2021-07-27T13:32:29Z

@matthewejones Do you know if PR #87 gets obsolete when this is merged?

Mongo DB shouldn't be required at all after this update. It just uses node-persist.

So it should be obsolete

matthewejones · 2021-07-28T11:40:05Z

A bit more research into continuing to use MongoDB:

Database connectors in boardgame.io are supposed to be external libraries. e.g. bgio-firebase, bgio-azure-storage, bgio-postgres, etc.
No one has made one for Mongo db though.
There is however this comment with an implementation for the mongo db connector:
- Storage boardgameio/boardgame.io#6 (comment)

Using this I could probably set it up to continue using mongo or I guess we could just point anyone wanting to know in the right direction. Let me know what you think @ChristophNiehoff

ChristophNiehoff · 2021-07-28T11:48:05Z

I'd say, it's not our duty to implement a mongodb connector. Especially as we don't know if someone is actually using it. But I think we should document your findings in case someone wants to do it at some point. Maybe add a section to readme.md? Or add a dedicated file in which we write down such things?

src/server/publicApi.js

ChristophNiehoff · 2021-07-29T08:33:44Z

README.md

+As of boardgame.io v0.39.0, MongoDB is no longer supported as a database connector. There is currently no external library providing this functionality, however there is an [implementation](https://github.com/boardgameio/boardgame.io/issues/6#issuecomment-656144940) posted on github.
+
+
+In order for the architectural model of the system to be saved to the database, the functions `setModel` and `fetch` will also need to be implemented. All the code relating to the database connector is in src/server/config.js


Maybe we'll need more details here. Could you explain what exactly setModel and fetch are? Some functions from an interface? Which?

Do you also have to explain that don't only have to implement a connector but also implement an equivalent of ModelFlatFile?

I've tried to add a bit more information, let me know if it's still a bit unclear.

src/client/components/board/board.js

src/client/components/status/status.js

src/server/gameServer.js

src/utils/utils.js

src/game/eop.js

ChristophNiehoff · 2021-07-29T09:44:56Z

src/game/eop.js

+    scores[ctx.playerID]++;
+  }
+
+  // TODO: have a cleaner or readable approach to updating this object


I'm not really sure of a cleaner way to do this, I might have a think about it and come back to it.

src/game/eop.js

ChristophNiehoff

@matthewejones I REALLY like how you cleaned up eop.js!!!

ChristophNiehoff · 2021-08-03T06:41:59Z

src/client/components/board/board.js

-      current = true;
-    }
+    const current = this.props.playerID === this.props.ctx.currentPlayer
+    // ? true : false to stop isInThreatStage taking undefined if this.props.ctx.activePlayers is undefined


Is this comment still up-to-date?

ChristophNiehoff · 2021-08-03T06:44:56Z

src/client/components/leaderboard/leaderboard.js

@@ -41,7 +41,7 @@ class Leaderboard extends React.Component {
                <td>
                  {hasPassed(idx, this) && <div align="center">&#10003;</div>}
                </td>
-                <td><strong>{this.props.cards[idx]}</strong></td>
+                <td><strong>{this.props.cards[idx] ? this.props.cards[idx] : ''}</strong></td>


Syntactic sugar:
I believe you could wirte this using the nullish coalescing operator

<td><strong>{this.props.cards[idx] ?? ''}</strong></td>

Just tried this, unfortunately it threw this error:

SyntaxError: C:\Users\jonesm\Documents\elevation-of-privilege\src\client\components\leaderboard\leaderboard.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled (44:52):

I can use || in this case even if I can't use ?? because cards will never be falsy but not null/undefined. So I think I'll just do this

…evation-of-privilege into updateboardgame

matthewejones commented Jul 28, 2021

View reviewed changes

src/server/publicApi.js Show resolved Hide resolved

ChristophNiehoff requested changes Jul 29, 2021

View reviewed changes

ChristophNiehoff approved these changes Aug 3, 2021

View reviewed changes

matthewejones added 20 commits August 4, 2021 10:52

update boardgame.io to 0.38.1

0b7a724

update boardgame.io to 0.38.1

977c2a8

take functions out of game definition

f223cb4

remove game constructor

2c6defe

update syntax of game definition

707a1ad

replaced client.connect() with client.start()

5908b34

change {local:true} to Local()

08cc615

replaced allowedMoves with moves

cb098a1

use setActivePlayers instead of activePlayers

caa1f76

add test to test that players are active

301bc4a

replaced order functions with arrow functions

2d35670

fixed turnorder tests

8bed844

G.order now uses strings, fixed turnorder

6402423

replaced {server:} with SocketIO({server:})

3a28202

reworked actionPlayers

a8576ff

removed phases

28297ef

fixed infinite loop problem

2ce0b8e

add missing line from test

4faeb2d

use stages instead of phases

a25459c

replace phase with isInThreatStage

ea0dc43

matthewejones and others added 25 commits August 4, 2021 10:54

replace all gameID with matchID

966fb5d

test names when testing player info

115dbf3

Merge branch 'master' into updateboardgame

472a76f

replaced db.set with db.setItem in new test

8322a51

replace gameID with matchID in merged files

ecaf181

replace db.get with db.getItem in new files

c2998ac

stopped test from running async functions

e9ce890

removed gameName from db.set/getItem

0f0d9f0

remove mongo

9048e2a

reworked turnorder

7bdbe8d

fixed tests

ab9f1a4

Merge branch 'master' into updateboardgame

6f19b75

Merge branch 'master' into updateboardgame

411a123

Rework db connector, update readme

a8e4ae5

edited readme

7ac32b6

delete a comment

c0e02c9

refactor eop.js

d84168d

refactor ModelFlatFile

a3bce29

Merge branch 'updateboardgame' of https://github.com/matthewejones/el…

5384a4c

…evation-of-privilege into updateboardgame

Small changes

ada4d24

change tests

9ee6de6

Added more info to readme

6ded2d4

fixed small bug with isInThreatStage

f20ef16

neaten up

4fb139b

Merge branch 'master' into updateboardgame

1b9fc62

matthewejones force-pushed the updateboardgame branch from 2e983bc to 1b9fc62 Compare August 4, 2021 09:32

missed a gameID when rebasing

1433392

matthewejones mentioned this pull request Aug 9, 2021

validate player secrets on public API requests #125

Merged

Merge branch 'master' into updateboardgame

13423f1

ChristophNiehoff merged commit 9a9f58b into dehydr8:master Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update boardgame.io to 0.45.2 #105

Update boardgame.io to 0.45.2 #105

matthewejones commented Jul 21, 2021 •

edited by ChristophNiehoff

Loading

matthewejones commented Jul 21, 2021

matthewejones commented Jul 22, 2021

matthewejones commented Jul 27, 2021

ChristophNiehoff commented Jul 27, 2021

matthewejones commented Jul 27, 2021

matthewejones commented Jul 28, 2021

ChristophNiehoff commented Jul 28, 2021

ChristophNiehoff Jul 29, 2021

ChristophNiehoff Jul 29, 2021

matthewejones Aug 2, 2021

ChristophNiehoff Jul 29, 2021

matthewejones Aug 2, 2021

ChristophNiehoff left a comment

ChristophNiehoff Aug 3, 2021

ChristophNiehoff Aug 3, 2021

matthewejones Aug 3, 2021

		As of boardgame.io v0.39.0, MongoDB is no longer supported as a database connector. There is currently no external library providing this functionality, however there is an [implementation](https://github.com/boardgameio/boardgame.io/issues/6#issuecomment-656144940) posted on github.


		In order for the architectural model of the system to be saved to the database, the functions `setModel` and `fetch` will also need to be implemented. All the code relating to the database connector is in src/server/config.js

Update boardgame.io to 0.45.2 #105

Update boardgame.io to 0.45.2 #105

Conversation

matthewejones commented Jul 21, 2021 • edited by ChristophNiehoff Loading

matthewejones commented Jul 21, 2021

matthewejones commented Jul 22, 2021

matthewejones commented Jul 27, 2021

ChristophNiehoff commented Jul 27, 2021

matthewejones commented Jul 27, 2021

matthewejones commented Jul 28, 2021

ChristophNiehoff commented Jul 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChristophNiehoff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthewejones commented Jul 21, 2021 •

edited by ChristophNiehoff

Loading