Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dockerfile): cleanup after installation a bit more than before and keep copyright / license files #113

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

helgi
Copy link
Contributor

@helgi helgi commented Sep 26, 2016

No description provided.

@helgi helgi added this to the v2.6 milestone Sep 26, 2016
@helgi helgi self-assigned this Sep 26, 2016
@deis-bot
Copy link

@mboersma, @bacongobbler and @jeroenvisser101 are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@mboersma mboersma added the LGTM1 label Sep 27, 2016
@@ -8,8 +8,25 @@ RUN addgroup --quiet --gid 2000 slug && \
RUN sed -i -e 's/^deb-src/#deb-src/' /etc/apt/sources.list && \
apt-get update && \
apt-get install -y md5deep && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/man /usr/share/doc && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see /tmp/* and /var/tmp/* removed below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point - may have to redo all my PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmala having looked at other images, that always seems to be empty even without that removal - is there anything we place in /tmp or /var/tmp ourselves?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmala ah right but that is when we build slugs, not when we build the image for the slugbuilder itself, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@kmala kmala added the LGTM2 label Sep 27, 2016
@helgi helgi merged commit 2a7769d into deis:master Sep 27, 2016
@helgi helgi deleted the update_image branch September 27, 2016 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants