-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Dockerfile): cleanup after installation a bit more than before and keep copyright / license files #113
Conversation
…and keep copyright / license files
@mboersma, @bacongobbler and @jeroenvisser101 are potential reviewers of this pull request based on my analysis of |
@@ -8,8 +8,25 @@ RUN addgroup --quiet --gid 2000 slug && \ | |||
RUN sed -i -e 's/^deb-src/#deb-src/' /etc/apt/sources.list && \ | |||
apt-get update && \ | |||
apt-get install -y md5deep && \ | |||
apt-get clean && \ | |||
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/man /usr/share/doc && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see /tmp/* and /var/tmp/* removed below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point - may have to redo all my PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmala having looked at other images, that always seems to be empty even without that removal - is there anything we place in /tmp or /var/tmp ourselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use /tmp during the slug building process https://github.com/deis/slugbuilder/blob/master/rootfs/builder/build.sh#L14-L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmala ah right but that is when we build slugs, not when we build the image for the slugbuilder itself, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
No description provided.