File deduplication, Android part #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
9750e7b to
d5503f6
Compare
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
e3ddc7b to
3ef45d2
Compare
14 tasks
Hocuri
force-pushed
the
hoc/file-deduplication
branch
3 times, most recently
from
73a9f89 to
e213b6a
Compare
2 tasks
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
e213b6a to
7daf12f
Compare
Hocuri
changed the title
|
Probably I should bump the core submodule in this PR so that building the preview APK succeeds? (it's failing because Android now depends on the new |
|
To test the changes in this pull request, install this apk: |
adbenitez
force-pushed
the
hoc/file-deduplication
branch
from
2286fb5 to
a5f80f5
Compare
adbenitez
reviewed
Jan 27, 2025
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on chatmail/core#6332.
Remaining bugs:
When sharing an image to DC (or when drafting and re-entering a chat), the dimensions aren't calculated correctlyFixed thanks to adbWhen sharing a video to DC (or when drafting and re-entering a chat) and then clicking on the draft to preview it, I only get a black screenWorks fine with feat: Keep file extension on deduplicated files chatmail/core#6463