Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add "Changelog" device message for new accounts #3637

Closed
r10s opened this issue Jan 20, 2024 · 1 comment · Fixed by #3639
Closed

do not add "Changelog" device message for new accounts #3637

r10s opened this issue Jan 20, 2024 · 1 comment · Fixed by #3639
Assignees
Labels
wait-for-core Waiting for an related core issue to be resolved

Comments

@r10s
Copy link
Member

r10s commented Jan 20, 2024

the "Changelog" device messages should be added only for real updates

on new installations or accounts, the "What's new?" messages only clutters the device messages with unimportant information (either the user is new to the app, so everyrhing is new and nothing is changed, or an existing user has created a new account, they have seen the changelog anyways)

this is esp. important new as we aim to add information wrt getting in contact for chatmail users, however, it was a bit annoying all the time.

moreover, this makes untranslated changelogs less annoying as the user is not confronted with a language mix upfront.

when reading https://c.delta.chat/classdc__context__t.html#a1a2aad98bd23c1d21ee42374e241f389 , not added changelog on updates was always the gist, however, somehow forgotten or removed on the way :)

(technically, we cannot use the pattern from the example as the "welcome" message is added by come in some threads, so we need to track if the account was just created somehow, on android we do that by passing a flag around, see deltachat/deltachat-android#2935) (still, label needs to be set with msg=null to avoid future adding)

@Simon-Laux
Copy link
Member

note: setting an empty / null pointer device message is not supported by jsonrpc yet
so this required core changes.

@Simon-Laux Simon-Laux added the wait-for-core Waiting for an related core issue to be resolved label Jan 22, 2024
@Simon-Laux Simon-Laux self-assigned this Jan 24, 2024
@adzialocha adzialocha assigned adzialocha and unassigned Simon-Laux Jan 31, 2024
Simon-Laux added a commit that referenced this issue Feb 3, 2024
* do not add changelog device message on fresh accounts

closes #3637

depends on chatmail/core#5211

* changelog entry

* apply code review suggestions

* Remove dead code

---------

Co-authored-by: adz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-for-core Waiting for an related core issue to be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants