Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up dependencies #2314

Closed
wants to merge 5 commits into from

Conversation

dotlambda
Copy link
Contributor

No description provided.

@dotlambda dotlambda force-pushed the clean-up-dependencies branch from 4828910 to 630877e Compare July 23, 2021 16:39
@dotlambda
Copy link
Contributor Author

dotlambda commented Jul 23, 2021

Package "electron-builder" is only allowed in "devDependencies". Please remove it from the "dependencies" section in your package.json.

I guess optionalDependencies is really meant for optional run-time dependencies. I would however love to be able to distinguish between test and CI dependencies and those which are strictly necessary for building deltachat-desktop.
Also see npm/npm#3870.

@Simon-Laux
Copy link
Member

I'd like to get #2303 merged before this one, also if we should go the optionalDependencies route we should mention what installation command you need in the readme/docs before the functions that need those "optional" dependencies.

Also it looks like electron builder does not like to be an optional dependency:

Package "electron-builder" is only allowed in "devDependencies". Please remove it from the "dependencies" section in your package.json.

@dotlambda
Copy link
Contributor Author

Since optionalDevDependencies is not a thing, it might be a better option to have two package.json files: https://www.electron.build/tutorials/two-package-structure

@Simon-Laux
Copy link
Member

yeah also thought about that, that could be a solution. depending on how many files need to be moved... can we somehow do it without moving the whole source dir inside into an app folder, If not I'd rather do this when we don't have many PRs open.

CC @Jikstra what do you think?

@dotlambda dotlambda closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants