-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up dependencies #2314
clean up dependencies #2314
Conversation
4828910
to
630877e
Compare
630877e
to
e5a2a9c
Compare
I guess |
I'd like to get #2303 merged before this one, also if we should go the optionalDependencies route we should mention what installation command you need in the readme/docs before the functions that need those "optional" dependencies. Also it looks like electron builder does not like to be an optional dependency:
|
Since |
yeah also thought about that, that could be a solution. depending on how many files need to be moved... can we somehow do it without moving the whole source dir inside into an app folder, If not I'd rather do this when we don't have many PRs open. CC @Jikstra what do you think? |
No description provided.