improvement: add arrow-key nav everywhere #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and "New Broadcast List". Just for the "Members list" section.
WofWca
force-pushed
the
wofwca/arrow-keys-everywhere
branch
from
531ae69 to
ac7df20
Compare
- Mailto - webxdc.sendToChat - Forward Message
With this commit now all `ChatListPart`s are wrapped in `<RovingTabindexProvider>`.
WofWca
force-pushed
the
wofwca/arrow-keys-everywhere
branch
from
ac7df20 to
0c29803
Compare
This is needed so that we can use hooks inside the `ReactionsDialogListItem`, namely the `useRovingTabindex` hook.
WofWca
changed the title
This was referenced Nov 29, 2024
nicodh
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have shallowly tested all the places where added it.
This completes arrow-key navigation for all the chat lists and contact lists, unless I missed something.
Follow up to #4224, #4291, #4361, #4362.
For easier review, hide white-space changes.
This MR includes one small refactor commit, otherwise it's just boilerplate.
And about boilerplate: please tell me whether in general this looks like a good way to write this, or if this feels wrong and unmaintainable.