style: "Search in ..." divider overflow #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-search-divider-overflow
branch
2 times, most recently
from
a9f8592 to
ff52025
Compare
|
To keep in mind: For this search in chat divider it does not matter, but height might matter for the other dividers in the global search. |
Simon-Laux
approved these changes
Nov 30, 2024
Those should not wrap because they only show "999+ messages / contacts / chats", unless the translation is super long. |
This change should only really affect the "search in" divider. Other dividers with the same class name shouldn't be overflowing, unless the translation is super long, but either way this should be better than truncating.
WofWca
force-pushed
the
wofwca/fix-search-divider-overflow
branch
from
ff52025 to
3c80473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Reported by @adbenitez